Fixes #1174358 remove dupe code/driveby route fix

app/subapps/browser/views/charmresults.js

 'use strict';
 
 
 /**
  * Charm Results View.
  *
  * @module juju.browser
  * @submodule views
  *
  */
@@ skipping 12 matching lines @@
      Since this view is incomplete (has no render, template, etc.) it's not
      tested directly, but through the SearchView and the EditorialView which
      verify both rendering and expected event behavior.
 
      @class CharmReults
      @extends {juju.browser.views.CharmResults}
 
    */
   ns.CharmResults = Y.Base.create('browser-view-charmresults', Y.View, [
     views.utils.apiFailingView,
-    widgets.browser.IndicatorManager
+    widgets.browser.IndicatorManager,
+    Y.Event.EventTracker
   ], {
     events: {
       '.charm-token': {
         click: '_handleCharmSelection'
       }
     },
 
     /**
        Watch for selecting a charm in the results.
 
        @method _bindEvents
 
      */
     _bindEvents: function() {
       // Watch for changse to the activeID so that we can mark/unmark active
       // as required.
-      this.on('activeIDChange', function(ev) {

[j.c.sackett, 2013/05/13 18:34:05]

We should probaby catch this and detach it on destroy, right? Maybe just use
eventmanager?

[rharding, 2013/05/14 10:54:08]

Definitely, thanks.

-        var id = ev.newVal;
-        if (id) {
-          id = this.get('container').one(
-              '.charm-token[data-charmid="' + id + '"]');
-        }
-        this._updateActive(id);
-      });
+      this.addEvent(
+          this.on('activeIDChange', function(ev) {
+            var id = ev.newVal;
+            if (id) {
+              id = this.get('container').one(
+                  '.charm-token[data-charmid="' + id + '"]');
+            }
+            this._updateActive(id);
+          })
+      );
     },
 
     /**
         When selecting a charm from the list make sure we re-route the app to
         the details view with that charm selected.
 
         @method _handleCharmSelection
         @param {Event} ev the click event handler for the charm selected.
 
      */
@@ skipping 24 matching lines @@
     _updateActive: function(clickTarget) {
       // Remove the active class from any nodes that have it.
       Y.all('.yui3-charmtoken.active').removeClass('active');
 
       // Add it to the current node.
       if (clickTarget) {
         clickTarget.ancestor('.yui3-charmtoken').addClass('active');
       }
     },
 
-    /**
-     * Generates a message to the user based on a bad api call.
-     * @method apiFailure
-     * @param {Object} data the json decoded response text.
-     * @param {Object} request the original io_request object for debugging.
-     */
-    apiFailure: function(data, request) {
-      this._apiFailure(data, request, 'Failed to load editorial content.');

[j.c.sackett, 2013/05/13 18:34:05]

This is the wrong place for this; leave it in the editorial view, since the
error message is just for editorial. Search should have its own version which
mentions an error loading search results.

[rharding, 2013/05/14 10:54:08]

Yep, thanks. I'll keep this on its own between the two.

-    },
+
 
     /**
      * General YUI initializer.
      *
      * @method initializer
      * @param {Object} cfg configuration object.
      *
      */
     initializer: function(cfg) {
       // Hold onto charm data so we can pass model instances to other views when
@@ skipping 14 matching lines @@
   }, {
     ATTRS: {
       /**
        * The charm id to start out selected as active.
        *
        * @attribute setActive
        * @default undefined
        * @type {String}
        *
        */
-      activeID: {

[gary.poster, 2013/05/13 18:20:33]

trivial, but might as well collapse as you do elsewhere into activeId: {},

[rharding, 2013/05/14 10:54:08]

Sure thing.

-
-      },
+      activeID: {},
 
       /**
        * Is this rendering of the editorial view for fullscreen or sidebar
        * purposes?
        *
        * @attribute isFullscreen
        * @default false
        * @type {Boolean}
        */
       isFullscreen: {
@@ skipping 21 matching lines @@
   });
 
 }, '0.1.0', {
   requires: [
     'juju-models',
     'browser-overlay-indicator',
     'juju-view-utils',
     'view'
   ]
 });