Issue 9034046: whitelist regexp.options for ses on IE10

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9034046: whitelist regexp.options for ses on IE10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by felix8a

Modified:
12 years, 10 months ago

Reviewers:
Jasvir, MarkM, kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

IE10 has a magic readonly property RegExp.prototype.options that's a string of the regexp's options. For instance, /foo/i.options === "i". .options appears to be immune to deletion and poisoning, which causes ses to give up on IE10. This seems to be the only thing preventing ses/es5 from running on IE10. I don't see any reason to treat .options different from the other magic regexp properties, so I'm adding it to the whitelist.

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/com/google/caja/ses/whitelist.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages