src/cmd/gc/pgen.c - Issue 9033043: code review 9033043: cmd/gc: fix some overflows in the compiler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/pgen.c

Issue 9033043: code review 9033043: cmd/gc: fix some overflows in the compiler (Closed)

Patch Set: diff -r 3cbb458c93cf https://code.google.com/p/go/ Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/pgen.c

===================================================================

--- a/src/cmd/gc/pgen.c

+++ b/src/cmd/gc/pgen.c

@@ -177,8 +177,13 @@

{

if (a->class != b->class)

return (a->class == PAUTO) ? 1 : -1;

- if (a->class != PAUTO)

- return a->xoffset - b->xoffset;

+ if (a->class != PAUTO) {

+ if (a->xoffset < b->xoffset)

+ return -1;

+ if (a->xoffset > b->xoffset)

+ return 1;

+ return 0;

+ }

if ((a->used == 0) != (b->used == 0))

return b->used - a->used;

return b->type->align - a->type->align;

@@ -240,6 +245,10 @@

stksize = rnd(stksize, n->type->align);

if(thechar == '5')

stksize = rnd(stksize, widthptr);

+ if(stksize >= (1ULL<<31)) {

+ setlineno(curfn);

+ yyerror("stack frame too large (>2GB)");

+ }

n->stkdelta = -stksize - n->xoffset;

}

« no previous file with comments | « src/cmd/gc/go.h ('k') | src/cmd/gc/sinit.c » ('j') | no next file with comments »