src/cmd/gc/align.c - Issue 9033043: code review 9033043: cmd/gc: fix some overflows in the compiler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/align.c

Issue 9033043: code review 9033043: cmd/gc: fix some overflows in the compiler (Closed)

Patch Set: diff -r 3cbb458c93cf https://code.google.com/p/go/ Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/align.c

===================================================================

--- a/src/cmd/gc/align.c

+++ b/src/cmd/gc/align.c

@@ -46,7 +46,8 @@

widstruct(Type *errtype, Type *t, vlong o, int flag)

{

Type *f;

- int32 w, maxalign;

+ int64 w;

+ int32 maxalign;

maxalign = flag;

if(maxalign < 1)

@@ -643,7 +644,7 @@

{

Iter save;

Type *fp;

- int w, x;

+ int64 w, x;

w = 0;

@@ -664,5 +665,7 @@

}

w = (w+widthptr-1) & ~(widthptr-1);

+ if((int)w != w)

+ fatal("argsize too big");

return w;

}

« no previous file with comments | « src/cmd/8g/gsubr.c ('k') | src/cmd/gc/closure.c » ('j') | no next file with comments »