Issue 90310043: juju: Omit IPv6 and local addresses from jenv

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90310043: juju: Omit IPv6 and local addresses from jenv

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by gz

Modified:
10 years, 10 months ago

Reviewers:
mp+216744, wallyworld

Visibility:
Public.

Description

juju: Omit IPv6 and local addresses from jenv Until the jenv addresses cache gains the extra metadata fields that are returned over the API, filter out the addresses that are unlikely to be useful for connecting to an API server. https://code.launchpad.net/~gz/juju-core/api_endpoint_no_machine_local_1310258/+merge/216744 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/api.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	juju/apiconn_test.go	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

wallyworld

10 years, 10 months ago (2014-04-23 01:20:41 UTC) #2

I tested this with local provider and got:

- 10.0.1.1:17070
- localhost:17070
- 192.168.1.116:17070
- 172.16.48.1:17070
- 172.16.175.1:17070

So localhost is still included which is kinda cool because that's where the
state server runs for local provider. So even though the bug says localhost
should be excluded that's not entirely accurate. 

LGTM

Expand All Messages | Collapse All Messages