Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 90300043: Fix 026 exodus.

Can't Edit
Can't Publish+Mail
Start Review
5 years, 5 months ago by bac
5 years, 5 months ago
j.c.sackett, mp+216735


Fix 026 exodus. A basket, the thing ingested from Launchpad, contains one or more bundles. If there are multiple bundles they may establish an inheritance relationship between the bundles in that basket. The inheritance is done before the basket is split into individual bundles and stored -- flattened in other words. The 'inherits' line is not removed, however. When the exodus happens, the re-use of 'store_bundles' attempts to flatten again, but the relationship to the other bundle is invalid as the 'basket' now just contains the one pre-processed bundle. The fix for this exodus is to simply manually delete the 'inherits' key from the bundle_data before proceeding. The exodus has been tested against a full ingest of all charms and bundles. The unit test has been modified to include an 'inherits' key in the data, which is then ignored. https://code.launchpad.net/~bac/charmworld/exodus-026-fix/+merge/216735 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/migrations/versions/026_convert_comma_constraints.py View 2 chunks +2 lines, -1 line 0 comments Download
M charmworld/migrations/versions/tests/test_migrations.py View 1 chunk +4 lines, -2 lines 0 comments Download


Total messages: 2
Please take a look.
5 years, 5 months ago (2014-04-22 14:23:58 UTC) #1
5 years, 5 months ago (2014-04-22 14:27:05 UTC) #2
LGTM, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b