Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(351)

Issue 9024043: report firefox buildID in tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by felix8a
Modified:
12 years, 10 months ago
Reviewers:
Mark S. Miller, kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Firefox version numbers aren't necessarily precise enough for the types of bugs we care about, so this also tries to emit firefox's buildID too.

Patch Set 1 #

Patch Set 2 : report firefox buildID in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tests/com/google/caja/plugin/WebDriverHandle.java View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7
felix8a
12 years, 10 months ago (2013-04-30 00:23:41 UTC) #1
kpreid2
LGTM
12 years, 10 months ago (2013-04-30 16:40:28 UTC) #2
Mark S. Miller
Is < https://code.google.com/p/google-caja/source/browse/trunk/src/com/google/caja/ses/detect.js> relevant? Can/should this be improved to be more precise? On Tue, Apr ...
12 years, 10 months ago (2013-04-30 17:08:36 UTC) #3
felix8a
Firefox version numbers aren't necessarily precise enough for the types of bugs we care about, ...
12 years, 10 months ago (2013-05-01 05:50:34 UTC) #4
felix8a
Firefox version numbers aren't necessarily precise enough for the types of bugs we care about, ...
12 years, 10 months ago (2013-05-01 05:57:11 UTC) #5
felix8a
new snapshot. I was misled by firefox aurora, which has a substring like "Gecko/20130430" in ...
12 years, 10 months ago (2013-05-01 05:58:35 UTC) #6
kpreid2
12 years, 10 months ago (2013-05-01 17:05:24 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b