Issue 9014043: CPP: Move base/string_piece.* to base/strings/.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9014043: CPP: Move base/string_piece.* to base/strings/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by pliard1

Modified:
12 years, 7 months ago

Reviewers:
Shaopeng

CC:
lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Move base/string_piece.* to base/strings/. This change is needed to embed libphonenumber into Chromium past r191206. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=566

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -418 lines)			Patch
M	cpp/CMakeLists.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
D	cpp/src/base/string_piece.h	View	1 chunk	+0 lines, -192 lines	0 comments	Download
D	cpp/src/base/string_piece.cc	View	1 chunk	+0 lines, -219 lines	0 comments	Download
A +	cpp/src/base/strings/string_piece.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	cpp/src/base/strings/string_piece.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cpp/src/phonenumbers/utf/stringpiece.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pliard1

On 2013/04/29 14:23:18, Shaopeng wrote: > LGTM Thanks Shaopeng!

12 years, 7 months ago (2013-04-29 15:23:18 UTC) #3

pliard1

12 years, 7 months ago (2013-04-29 15:23:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r566 (presubmit successful).

Expand All Messages | Collapse All Messages