code review 901042: exp/eval: Fix example and add target to Makefile

exp/eval: Fix example and add target to Makefile

[eds, 2010-04-10 04:12:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc, 2010-04-10 05:17:24]

> +main.$O: main.go package

instead of package, which will cause make to rebuild
everything each time it is run even when things are
up to date, could you make this depend on the
installed file name?  $(pkgdir)/$(TARG).a

thanks.
russ

[eds, 2010-04-10 14:29:13]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-04-10 19:24:17]

LGTM

please fix the one thing below and i'll submit it

http://codereview.appspot.com/901042/diff/7001/8002
File src/pkg/exp/eval/main.go (right):

http://codereview.appspot.com/901042/diff/7001/8002#newcode8
src/pkg/exp/eval/main.go:8: "exp/eval"
sorry, one more nit - this should be sorted down into the main list

[eds, 2010-04-10 19:29:29]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-04-11 19:42:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=85718323a1dc ***

exp/eval: Fix example and add target to Makefile

R=rsc
CC=golang-dev
http://codereview.appspot.com/901042

Committer: Russ Cox <rsc@golang.org>