Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(695)

Issue 90067: fix 1050, misplaced htmlemitter.finish() call (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by felix8a
Modified:
16 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M src/com/google/caja/plugin/templates/SafeHtmlMaker.java View 1 chunk +5 lines, -5 lines 1 comment Download
M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java View 1 chunk +40 lines, -0 lines 4 comments Download

Messages

Total messages: 3
felix8a
16 years, 11 months ago (2009-07-01 11:00:17 UTC) #1
ihab.awad
LGTM++ _modulo_ comments. http://codereview.appspot.com/90067/diff/1/3 File src/com/google/caja/plugin/templates/SafeHtmlMaker.java (right): http://codereview.appspot.com/90067/diff/1/3#newcode245 Line 245: && i + 1 != ...
16 years, 11 months ago (2009-07-06 23:50:35 UTC) #2
ihab.awad
16 years, 11 months ago (2009-07-06 23:52:59 UTC) #3
Almost forgot! 2 more formatting issues. Still LGTM++.

http://codereview.appspot.com/90067/diff/1/2
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/90067/diff/1/2#newcode306
Line 306: + "<div id=a></div>"
For consistency, quote attrs: "...id=\"a\"..."

http://codereview.appspot.com/90067/diff/1/2#newcode311
Line 311: + "<div id='id_1___'></div>"
For consistency, double quote attrs: "...id=\"id_1___\"..."
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b