Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1054)

Issue 8977043: Make the browser always part of the default UX

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
bcsaller, mp+161156, matthew.scott
Visibility:
Public.

Description

Make the browser always part of the default UX - Remove the /bws/ prefix on the routes and all instances of it. - Add a new route for / and /*charmid - Add a couple of tests to verify the new routes will route correctly, defaulting to the sidebar view - Update the browser app and the Charmworld0 store api handler to allow for a nop since not all tests will want to setup a fake store api endpoint. Since the browser is always visible, it wants to try to always load editorial content. The nop allows it to carry on but will hit the apifailure call so that it should not silently hide failures. https://code.launchpad.net/~rharding/juju-gui/browser-default/+merge/161156 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make the browser always part of the default UX #

Total comments: 2

Patch Set 3 : Make the browser always part of the default UX #

Patch Set 4 : Make the browser always part of the default UX #

Patch Set 5 : Make the browser always part of the default UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -90 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/charm.js View 1 2 3 chunks +29 lines, -1 line 0 comments Download
M app/subapps/browser/browser.js View 1 2 3 4 8 chunks +68 lines, -14 lines 0 comments Download
M app/subapps/browser/views/view.js View 2 chunks +1 line, -5 lines 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 1 2 3 4 23 chunks +170 lines, -69 lines 0 comments Download

Messages

Total messages: 7
rharding
Please take a look.
11 years ago (2013-04-26 16:19:14 UTC) #1
rharding
Please take a look.
11 years ago (2013-04-26 16:28:55 UTC) #2
bcsaller
LGTM Took me a while to grok some of the changes but this makes sense ...
11 years ago (2013-04-26 16:52:37 UTC) #3
rharding
Please take a look.
11 years ago (2013-04-26 17:24:14 UTC) #4
rharding
Please take a look.
11 years ago (2013-04-26 18:11:39 UTC) #5
rharding
Please take a look.
11 years ago (2013-04-26 19:04:59 UTC) #6
matthew.scott
11 years ago (2013-04-26 19:37:58 UTC) #7
LGTM - thanks for the work!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b