Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(297)

Issue 8913045: Fix SES crashing if unsupported since r5359. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by kpreid2
Modified:
13 years, 3 months ago
Reviewers:
MarkM, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* StringMap.js assumed ses.es5ProblemReports existed; fixed. * Added browser tests that initSES runs to completion even on (simulated) unsupported browsers. @r5367

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M src/com/google/caja/ses/StringMap.js View 1 chunk +2 lines, -1 line 3 comments Download
M tests/com/google/caja/ses/SESBrowserTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M tests/com/google/caja/ses/test-ses.html View 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6
kpreid2
13 years, 3 months ago (2013-04-22 21:47:54 UTC) #1
ihab.awad
lgtm
13 years, 3 months ago (2013-04-22 21:54:08 UTC) #2
kpreid2
On 2013/04/22 21:54:08, ihab.awad wrote: > lgtm OK, waiting for approval from MarkM.
13 years, 3 months ago (2013-04-23 00:00:25 UTC) #3
MarkM
LGTM https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringMap.js File src/com/google/caja/ses/StringMap.js (right): https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringMap.js#newcode46 src/com/google/caja/ses/StringMap.js:46: // Object.create(null) is broken; fall back to ES3-style ...
13 years, 3 months ago (2013-04-23 01:56:42 UTC) #4
kpreid2
https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringMap.js File src/com/google/caja/ses/StringMap.js (right): https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringMap.js#newcode46 src/com/google/caja/ses/StringMap.js:46: // Object.create(null) is broken; fall back to ES3-style implementation ...
13 years, 3 months ago (2013-04-23 02:01:03 UTC) #5
MarkM
13 years, 3 months ago (2013-04-23 02:09:21 UTC) #6
https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringM...
File src/com/google/caja/ses/StringMap.js (right):

https://codereview.appspot.com/8913045/diff/1/src/com/google/caja/ses/StringM...
src/com/google/caja/ses/StringMap.js:46: // Object.create(null) is broken; fall
back to ES3-style implementation
The code also covers the case where ses.es5ProblemReports doesn't exist. The
comment leaves this out of the explanation.

I don't feel strongly about this. If you feel strongly to the contrary, leave
this alone. LGTM anyway.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b