Issue 8911046: c2s_max_window_bits parameter for a client can be configured only if the client allows it.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8911046: c2s_max_window_bits parameter for a client can be configured only if the client allows it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Yutaka Hirano

Modified:
13 years ago

Reviewers:
tyoshino (chromium.org)

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

c2s_max_window_bits parameter for a client can be configured only if the client allows it. Committed: https://code.google.com/p/pywebsocket/source/detail?r=763

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/mod_pywebsocket/extensions.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/test/test_extensions.py	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yutaka Hirano

13 years ago (2013-04-24 01:16:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r763 (presubmit successful).

Expand All Messages | Collapse All Messages