Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 891050: code review 891050: gc: zero unnamed return values on entry if func has defer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by rsc
Modified:
14 years, 11 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: zero unnamed return values on entry if func has defer

Patch Set 1 #

Patch Set 2 : code review 891050: gc: zero unnamed return values on entry if func has defer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M src/cmd/gc/walk.c View 3 chunks +10 lines, -4 lines 0 comments Download
A test/fixedbugs/bug266.go View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-04-12 21:28:25 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=75df11ac659b *** gc: zero unnamed return values on entry if func has ...
14 years, 11 months ago (2010-04-12 21:28:29 UTC) #2
ken3
14 years, 11 months ago (2010-04-13 01:00:56 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b