Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

Issue 89063: Php shindig handlers change

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by Jinhui Du
Modified:
16 years, 7 months ago
Reviewers:
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Changes the handler constructors to make the config for unsupported service easier. If the container doesn't support any services just remove the service or specify an empty string as the service name. New handler(service) added won't affect the existing containers config when the container is upgraded.

Patch Set 1 #

Patch Set 2 : personService in person handler is not refactored properly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
php/config/container.php View 1 1 chunk +3 lines, -1 line 0 comments Download
php/src/social/service/ActivityHandler.php View 1 3 chunks +5 lines, -4 lines 0 comments Download
php/src/social/service/AlbumHandler.php View 1 2 chunks +1 line, -19 lines 0 comments Download
php/src/social/service/AppDataHandler.php View 1 4 chunks +4 lines, -3 lines 0 comments Download
php/src/social/service/DataRequestHandler.php View 1 2 chunks +24 lines, -1 line 0 comments Download
php/src/social/service/InvalidateHandler.php View 1 3 chunks +13 lines, -10 lines 0 comments Download
php/src/social/service/MediaItemHandler.php View 1 2 chunks +1 line, -15 lines 0 comments Download
php/src/social/service/MessagesHandler.php View 1 4 chunks +5 lines, -3 lines 0 comments Download
php/src/social/service/PersonHandler.php View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 1
Jinhui Du
16 years, 7 months ago (2009-06-30 06:01:40 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b