Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(676)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
890041
: Make CXXScopeSpec invalid when incomplete (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by
Jeffrey Yasskin
Modified:
14 years, 8 months ago
Reviewers:
Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.
Description
This fixes a bunch of redundant errors and bad recoveries.
Patch Set 1
#
Patch Set 2 : Propagate the bad scope into any declarator it's part of
#
Created:
14 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+127 lines, -133 lines
)
Patch
M
include/clang/Parse/Action.h
View
1
22 chunks
+22 lines, -22 lines
0 comments
Download
M
include/clang/Parse/Parser.h
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lib/Frontend/PrintParserCallbacks.cpp
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lib/Parse/MinimalAction.cpp
View
1
4 chunks
+4 lines, -4 lines
0 comments
Download
M
lib/Parse/ParseDecl.cpp
View
2 chunks
+8 lines, -7 lines
0 comments
Download
M
lib/Parse/ParseDeclCXX.cpp
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lib/Sema/Sema.h
View
1
27 chunks
+33 lines, -32 lines
0 comments
Download
M
lib/Sema/SemaCXXScopeSpec.cpp
View
1
7 chunks
+13 lines, -10 lines
0 comments
Download
M
lib/Sema/SemaCodeComplete.cpp
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lib/Sema/SemaDecl.cpp
View
1
3 chunks
+3 lines, -3 lines
0 comments
Download
M
lib/Sema/SemaDeclCXX.cpp
View
1
5 chunks
+5 lines, -5 lines
0 comments
Download
M
lib/Sema/SemaExpr.cpp
View
1
7 chunks
+7 lines, -7 lines
0 comments
Download
M
lib/Sema/SemaExprCXX.cpp
View
1
2 chunks
+2 lines, -2 lines
0 comments
Download
M
lib/Sema/SemaLookup.cpp
View
1
2 chunks
+2 lines, -2 lines
0 comments
Download
M
lib/Sema/SemaTemplate.cpp
View
1
7 chunks
+7 lines, -7 lines
0 comments
Download
M
test/CXX/temp/temp.spec/temp.explicit/p3.cpp
View
1
2 chunks
+7 lines, -9 lines
0 comments
Download
M
test/SemaCXX/nested-name-spec.cpp
View
1
2 chunks
+3 lines, -5 lines
0 comments
Download
M
test/SemaTemplate/instantiate-function-params.cpp
View
1
1 chunk
+1 line, -2 lines
0 comments
Download
M
test/SemaTemplate/instantiate-typedef.cpp
View
1
1 chunk
+1 line, -2 lines
0 comments
Download
M
test/SemaTemplate/typename-specifier.cpp
View
1
2 chunks
+5 lines, -10 lines
0 comments
Download
Issue 890041: Make CXXScopeSpec invalid when incomplete (Closed)
Created 14 years, 8 months ago by Jeffrey Yasskin
Modified 14 years, 8 months ago
Reviewers:
Base URL: https://llvm.org/svn/llvm-project/cfe/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b