Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(674)

Issue 8889044: JS: Add build.xml to compile and lint the code. Updated README with instructions how to compile and… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by tronikos1
Modified:
12 years, 7 months ago
Reviewers:
lararennie, shaopengjia
CC:
tronikos
Base URL:
http://libphonenumber.googlecode.com/svn/trunk/
Visibility:
Public.

Description

JS: Add build.xml to compile and lint the code. Updated README with instructions how to compile and use the library. Use demo.js and demo-compiled.js as example. Checking in demo-compiled.html and js to be linked from the project home page. Committed: https://code.google.com/p/libphonenumber/source/detail?r=565

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -437 lines) Patch
M javascript/README View 1 2 3 3 chunks +39 lines, -5 lines 0 comments Download
A javascript/build.xml View 1 2 1 chunk +137 lines, -0 lines 0 comments Download
D javascript/compile.sh View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
M javascript/i18n/phonenumbers/demo.html View 1 2 1 chunk +2 lines, -132 lines 0 comments Download
A + javascript/i18n/phonenumbers/demo.js View 3 chunks +36 lines, -67 lines 0 comments Download
A + javascript/i18n/phonenumbers/demo-compiled.html View 1 chunk +1 line, -140 lines 0 comments Download
A javascript/i18n/phonenumbers/demo-compiled.js View 1 2 1 chunk +507 lines, -0 lines 0 comments Download

Messages

Total messages: 6
tronikos1
12 years, 7 months ago (2013-04-23 04:31:22 UTC) #1
shaopengjia
Thanks a lot for doing this Nikolaos! Just a couple of minor comments, otherwise LGTM. ...
12 years, 7 months ago (2013-04-23 09:59:10 UTC) #2
tronikos1
https://codereview.appspot.com/8889044/diff/10001/javascript/README File javascript/README (right): https://codereview.appspot.com/8889044/diff/10001/javascript/README#newcode48 javascript/README:48: To use and compile the library in your own ...
12 years, 7 months ago (2013-04-23 19:57:38 UTC) #3
tronikos1
Committed patchset #4 manually as r565 (presubmit successful).
12 years, 7 months ago (2013-04-23 19:58:03 UTC) #4
tronikos1
I just submitted this. When you get a chance, could you please link to demo-compiled.html ...
12 years, 7 months ago (2013-04-23 20:00:35 UTC) #5
shaopengjia
12 years, 7 months ago (2013-04-24 07:27:53 UTC) #6
Message was sent while issue was closed.
On 2013/04/23 20:00:35, tronikos1 wrote:
> I just submitted this. When you get a chance, could you please link to
> demo-compiled.html from the project home page?

Done. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b