Issue 88870043: update helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88870043: update helpers

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by lomov.as

Modified:
11 years, 2 months ago

Reviewers:
benjamin.saller, mp+215018

Visibility:
Public.

Description

update helpers https://code.launchpad.net/~lomov-as/charm-helpers/cloud-foundry/+merge/215018 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -8 lines)			Patch
M	README.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmhelpers/contrib/cloudfoundry/common.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	charmhelpers/contrib/cloudfoundry/upstart_helper.py	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	test_requirements.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

benjamin.saller

11 years, 2 months ago (2014-04-17 15:20:44 UTC) #2

LGTM, thanks!


lbox submit 

should merge this for you

https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoun...
File charmhelpers/contrib/cloudfoundry/upstart_helper.py (right):

https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoun...
charmhelpers/contrib/cloudfoundry/upstart_helper.py:10: dirname =
os.path.join(hookenv.charm_dir(), 'files/upstart')
Thanks for fixing this. Much better not to run that code on import

Expand All Messages | Collapse All Messages