Issue 8882044: Re-implement instance terminators

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8882044: Re-implement instance terminators (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rafaelw

Modified:
10 years, 8 months ago

Reviewers:
arv, erik.arvidsson

CC:
mdv-reviews_googlegroups.com

Base URL:
https://github.com/toolkitchen/mdv.git@master

Visibility:
Public.

More Reviews

Description

Re-implement instance terminators so that insertion/remove is no longer linear. R=arv BUG= Committed: https://github.com/toolkitchen/mdv/commit/933f6bb

Patch Set 1 #

Total comments: 3

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -164 lines)			Patch
	M	src/template_element.js	View		8 chunks	+62 lines, -164 lines	3 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arv

11 years ago (2013-04-22 15:30:08 UTC) #1

Message was sent while issue was closed.

LGTM

https://codereview.appspot.com/8882044/diff/1/src/template_element.js
File src/template_element.js (right):

https://codereview.appspot.com/8882044/diff/1/src/template_element.js#newcode...
src/template_element.js:1040: if (!this.terminators.length)
We can skip this check. It looks like it will work correctly anyway.

https://codereview.appspot.com/8882044/diff/1/src/template_element.js#newcode...
src/template_element.js:1075: this.removeInstanceAt(splice.index);
We could potentially optimize this to remove all of them at once.

https://codereview.appspot.com/8882044/diff/1/src/template_element.js#newcode...
src/template_element.js:1086: this.insertInstanceAt(addIndex, fragment);
same here

Expand All Messages | Collapse All Messages