Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(516)

Issue 8881: GTest build broken on z/OS

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by Hobbes
Modified:
16 years, 5 months ago
Reviewers:
chandlerc, Zhanyong, googletestframework
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Obviously I missed something that should have been covered by the patch in http://codereview.appspot.com/7855/show. Unfortunately it wasn't until today that I had the chance to build on z/OS again.

Patch Set 1 #

Patch Set 2 : also remove comments about 'no autoconf' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
src/gtest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
Hobbes
17 years, 1 month ago (2008-12-02 18:20:15 UTC) #1
chandlerc
http://codereview.appspot.com/8881/diff/1/2 File src/gtest.cc (right): http://codereview.appspot.com/8881/diff/1/2#newcode69 Line 69: // No autoconf on z/OS While this line ...
17 years, 1 month ago (2008-12-02 18:26:36 UTC) #2
Zhanyong
http://codereview.appspot.com/8881/diff/1/2 File src/gtest.cc (right): http://codereview.appspot.com/8881/diff/1/2#newcode69 Line 69: // No autoconf on z/OS On 2008/12/02 18:26:37, ...
17 years, 1 month ago (2008-12-02 18:32:11 UTC) #3
Hobbes
also remove comments about 'no autoconf'
17 years, 1 month ago (2008-12-02 19:20:07 UTC) #4
chandlerc
17 years, 1 month ago (2008-12-02 19:52:15 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b