Issue 88800045: Fix a bug in Arm64 atomicops

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88800045: Fix a bug in Arm64 atomicops

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by rmcilroy

Modified:
10 years, 1 month ago

Reviewers:
xiaofeng

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix a bug in Arm64 atomicops. This was fixed in base in: https://codereview.chromium.org/237963017/ Also update with a couple of change since made to the base file to keep the two files consistent. BUG=354405

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -19 lines)			Patch
	M	src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h	View		7 chunks	+7 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

xiaofeng

10 years, 1 month ago (2014-05-05 22:07:49 UTC) #2

LGTM

Committed as r524

On 2014/04/23 11:32:26, rmcilroy wrote:
> PTAL.

Expand All Messages | Collapse All Messages