Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5340)

Issue 88800045: Fix a bug in Arm64 atomicops

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rmcilroy
Modified:
10 years, 6 months ago
Reviewers:
xiaofeng
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix a bug in Arm64 atomicops. This was fixed in base in: https://codereview.chromium.org/237963017/ Also update with a couple of change since made to the base file to keep the two files consistent. BUG=354405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h View 7 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 2
rmcilroy
PTAL.
10 years, 7 months ago (2014-04-23 11:32:26 UTC) #1
xiaofeng
10 years, 6 months ago (2014-05-05 22:07:49 UTC) #2
LGTM

Committed as r524

On 2014/04/23 11:32:26, rmcilroy wrote:
> PTAL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b