Remove legacy log functions.

Remove legacy log functions.

This branch removes the old log.Errorf, log.Noticef,
log.Infof, log.Debugf, and log.Warningf in favour of
loggo functions.

The rsyslog package is moved to be under utils, and
the LoggedErrorf is moved to the errors package.

A lot of very mechanical changes.

https://code.launchpad.net/~thumper/juju-core/remove-old-log-functions/+merge/216247

(do not edit description out of merge proposal)

[thumper, 2014-04-17 04:04:29]

Please take a look.

[dave_cheney.net, 2014-04-17 04:08:34]

On 2014/04/17 04:04:29, thumper wrote:
> Please take a look.

LGTM

[jameinel, 2014-04-17 04:54:21]

LGTM though the functions that used the "debugf" wrapper should probably
actually be dropped to Tracef level.

https://codereview.appspot.com/88800043/diff/1/state/presence/presence.go
File state/presence/presence.go (right):

https://codereview.appspot.com/88800043/diff/1/state/presence/presence.go#new...
state/presence/presence.go:22: var logger =
loggo.GetLogger("juju.state.presence")
These were all disabled by default, should we actually reduce them down to
Tracef?

https://codereview.appspot.com/88800043/diff/1/state/watcher/watcher.go
File state/watcher/watcher.go (left):

https://codereview.appspot.com/88800043/diff/1/state/watcher/watcher.go#oldco...
state/watcher/watcher.go:279: debugf("state/watcher: got request: %#v", req)
Same here, all of these were actually lower-than-debug because you had to
explicitly enable the whole package to log.

We could make "juju.state.watcher" disabled by default, but I think just turning
all of these into Tracef makes the most sense.