HA: upgrade upstart and initiate replset

HA: upgrade upstart and initiate replset

The machine agent will now upgrade the
Mongo upstart script and initiate the
replicaset when upgrading from a version
prior to 1.19.0.

Tested upgrading 1.18.1 to 1.19.1 with and
without HA enabled; tested straight bootstrap
to 1.19.1 with and without HA enabled.

(Supersedes https://codereview.appspot.com/88350043/)

https://code.launchpad.net/~axwalk/juju-core/lp1306902-ha-upgrade-take2/+merge/216245

(do not edit description out of merge proposal)

[axw, 2014-04-17 03:33:07]

Please take a look.

[rog, 2014-04-17 18:20:23]

LGTM with two minor suggestions.

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go#newcode438
cmd/jujud/machine.go:438: func (a *MachineAgent) ensureMongoServer(agentConfig
agent.Config) error {
can we put this after StateWorker, so functions read generally from higher level
to lower level?

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go#newcode468
cmd/jujud/machine.go:468: }
perhaps refresh agentConfig here?

(I actually think that ChangeConfig should probably always return the new
version of the agent configuration)

[axw, 2014-04-18 04:26:23]

Please take a look.

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go#newcode438
cmd/jujud/machine.go:438: func (a *MachineAgent) ensureMongoServer(agentConfig
agent.Config) error {
On 2014/04/17 18:20:23, rog wrote:
> can we put this after StateWorker, so functions read generally from higher
level
> to lower level?

Done.

https://codereview.appspot.com/88790043/diff/1/cmd/jujud/machine.go#newcode468
cmd/jujud/machine.go:468: }
On 2014/04/17 18:20:23, rog wrote:
> perhaps refresh agentConfig here?
> 
> (I actually think that ChangeConfig should probably always return the new
> version of the agent configuration)

Done.

[axw, 2014-04-18 04:44:47]

Please take a look.