Issue 886043: code review 886043: fixes for rpc:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 886043: code review 886043: fixes for rpc: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by r

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, msolo, golang-dev

Visibility:
Public.

Description

fixes for rpc: - don't log normal EOF - fix ServeConn to block as documented

Patch Set 1 #

Patch Set 2 : code review 886043: fixes for rpc: #

Patch Set 3 : code review 886043: fixes for rpc: #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/rpc/server.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello rsc, msolo@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-12 23:55:42 UTC) #1

rsc

Mike and I talked about this some today. The accept fix is not quite right. ...

14 years, 11 months ago (2010-04-13 00:00:29 UTC) #2

Hello rsc, msolo (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-13 00:02:29 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1090b1484cc1 *** fixes for rpc: - don't log normal EOF - fix ...

14 years, 11 months ago (2010-04-13 00:14:30 UTC) #5

msolo

14 years, 11 months ago (2010-04-13 00:18:09 UTC) #6

On Mon, Apr 12, 2010 at 5:00 PM, Russ Cox <rsc@golang.org> wrote:
> Mike and I talked about this some today.
> The accept fix is not quite right.
> I think that we need to tweak the network
> error reporting a bit to make it really work.
> The rest of the CL looks good.
> Maybe revert the change to the Accept error case for now?

I'm fine with reverting this portion of the CL for now -- the fix to
ServeConn() is rather more critical for my immediate needs.


>
> Russ
>

Expand All Messages | Collapse All Messages