Issue 8859051: Better shape control of arpeggio brackets.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8859051: Better shape control of arpeggio brackets.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by lemzwerg

Modified:
12 years, 10 months ago

Reviewers:
janek, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Better shape control of arpeggio brackets.

Patch Set 2 : s/protrude/protrusion/ #

Patch Set 3 : s/protrude/protrusion/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
M	lily/arpeggio.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/define-grobs.scm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Trevor Daniels

https://codereview.appspot.com/8859051/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/8859051/diff/1/scm/define-grob-properties.scm#newcode737 scm/define-grob-properties.scm:737: (protrude ,number? "In an arpeggio bracket, the length of ...

12 years, 10 months ago (2013-04-29 09:09:42 UTC) #1

lemzwerg

OK, will use `protrusion'. `edge-length' is already taken, unfortunately, for exactly the same thing, namely ...

12 years, 10 months ago (2013-04-29 10:03:22 UTC) #2

LGTM

Expand All Messages | Collapse All Messages