Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(325)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8850043: Fix make dist errors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by fujiwara
Modified:
11 years, 1 month ago
Reviewers:
shawn.p.huang, Daiki Ueno, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Fix make dist errors.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M bindings/pygobject/Makefile.am View 1 chunk +5 lines, -1 line 0 comments Download
M bindings/vala/Makefile.am View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8
fujiwara
11 years, 1 month ago (2013-04-18 06:06:36 UTC) #1
Peng
On 2013/04/18 06:06:36, fujiwara wrote: lgtm
11 years, 1 month ago (2013-04-21 11:02:05 UTC) #2
Daiki Ueno
https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am File bindings/vala/Makefile.am (right): https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am#newcode53 bindings/vala/Makefile.am:53: DIST_SOURCES = $(VAPIGEN_VAPIS) Well, DIST_SOURCES is an internal variable ...
11 years, 1 month ago (2013-04-22 14:08:27 UTC) #3
fujiwara
On 2013/04/22 14:08:27, Daiki Ueno wrote: > https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am > File bindings/vala/Makefile.am (right): > > https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am#newcode53 ...
11 years, 1 month ago (2013-04-22 21:40:13 UTC) #4
Daiki Ueno
On 2013/04/22 21:40:13, fujiwara wrote: > On 2013/04/22 14:08:27, Daiki Ueno wrote: > > https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am ...
11 years, 1 month ago (2013-04-23 05:01:38 UTC) #5
fujiwara
On 2013/04/23 05:01:38, Daiki Ueno wrote: > On 2013/04/22 21:40:13, fujiwara wrote: > > On ...
11 years, 1 month ago (2013-04-23 09:36:49 UTC) #6
Daiki Ueno
On 2013/04/23 09:36:49, fujiwara wrote: > On 2013/04/23 05:01:38, Daiki Ueno wrote: > > On ...
11 years, 1 month ago (2013-04-23 10:03:05 UTC) #7
Peng
11 years, 1 month ago (2013-04-23 10:04:01 UTC) #8
Message was sent while issue was closed. 
On 2013/04/23 09:36:49, fujiwara wrote:
> On 2013/04/23 05:01:38, Daiki Ueno wrote:
> > On 2013/04/22 21:40:13, fujiwara wrote:
> > > On 2013/04/22 14:08:27, Daiki Ueno wrote:
> > > > https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am
> > > > File bindings/vala/Makefile.am (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.appspot.com/8850043/diff/1/bindings/vala/Makefile.am#newco...
> > > > bindings/vala/Makefile.am:53: DIST_SOURCES = $(VAPIGEN_VAPIS)
> > > > Well, DIST_SOURCES is an internal variable of automake.  What do you
want
> > > here?
> > > 
> > > make distdir creates DISTFILES.
> > 
> > So what?  Why not add them to EXTRA_DIST?
> 
> I don't mind it. If EXTRA_DIST is better, can update the patch again.

I think it is better to use EXTRA_DIST. We already use it many place.
Fujiwara-san, could you please update it. Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b