Issue 88490043: cmd/jujud: MachineWithCharmsSuite fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88490043: cmd/jujud: MachineWithCharmsSuite fix

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
mp+216105, natefinch

Visibility:
Public.

Description

cmd/jujud: MachineWithCharmsSuite fix We make MachineWithCharmsSuite use commonMachineSuite so that it gains from the commonMachineSuite mocking goodness. This requires a change to CharmSuite so that it can use a JujuConnSuite that's externally defined. https://code.launchpad.net/~rogpeppe/juju-core/555-jujud-charmsuite-use-commonmachinesuite/+merge/216105 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: MachineWithCharmsSuite fix #

Patch Set 3 : cmd/jujud: MachineWithCharmsSuite fix #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -59 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/bootstrap_test.go	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 2	4 chunks	+28 lines, -40 lines	0 comments	Download
M	state/api/charmrevisionupdater/updater_test.go	View	1	4 chunks	+18 lines, -0 lines	0 comments	Download
M	state/apiserver/charmrevisionupdater/testing/suite.go	View	1 2	7 chunks	+17 lines, -16 lines	0 comments	Download
M	state/apiserver/charmrevisionupdater/updater_test.go	View	1 2	4 chunks	+15 lines, -1 line	0 comments	Download
M	worker/charmrevisionworker/revisionupdater_test.go	View	1 2	4 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages