Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1130)

Issue 882043: code review 882043: change channel read to clear (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by ken3
Modified:
14 years, 12 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

change channel read to clear data just read from the channel. this will make it easier to recognize when to garbage collect and finalize.

Patch Set 1 #

Patch Set 2 : code review 882043: change channel read to clear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/pkg/runtime/chan.c View 6 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 12 months ago (2010-04-06 23:58:50 UTC) #1
ken3
*** Submitted as http://code.google.com/p/go/source/detail?r=57f45887d8df *** change channel read to clear data just read from the ...
14 years, 12 months ago (2010-04-06 23:58:54 UTC) #2
rsc
14 years, 12 months ago (2010-04-07 00:06:36 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b