a few small HA tweaks

a few small HA tweaks

- make sure we use localhost for stateinfo from the agent config
- dial all state addresses in parallel (no max)
- refesh the agentconfig after connecting to the api in case something changed

https://code.launchpad.net/~natefinch/juju-core/043-localstateinfo/+merge/215924

(do not edit description out of merge proposal)

[natefinch, 2014-04-15 16:46:46]

Please take a look.

[natefinch, 2014-04-15 16:56:35]

Please take a look.

[rog, 2014-04-15 17:05:38]

LGTM with some minor suggestions below

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go
File agent/agent_test.go (right):

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go#newcod...
agent/agent_test.go:437: func (*suite) TestSetPassword(c *gc.C) {
Not your fault, but this test doesn't seem to be named quite right any more...

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go#newcod...
agent/agent_test.go:438: attrparams := attributeParams
attrParams?

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go#newcod...
agent/agent_test.go:446: conf, err :=
agent.NewStateMachineConfig(attributeParams, servingInfo)
s/attributeParams/attrParams/

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go#new...
cmd/jujud/bootstrap.go:151: return fmt.Errorf("no stateinfo available")
"no state info available"

good to stick to english for errors, i think.

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go#new...
cmd/jujud/bootstrap.go:159: return fmt.Errorf("No stateservinginfo available")
"no state serving info available"

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go#newco...
cmd/jujud/machine.go:495: return nil, nil, fmt.Errorf("no stateinfo available")
s/stateinfo/state info/

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go#newco...
cmd/jujud/machine.go:591: return fmt.Errorf("no stateinfo available")
ditto

[natefinch, 2014-04-15 17:19:54]

Please take a look.

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go
File agent/agent_test.go (right):

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go#newcod...
agent/agent_test.go:438: attrparams := attributeParams
On 2014/04/15 17:05:38, rog wrote:
> attrParams?

Done.

https://codereview.appspot.com/88200043/diff/20001/agent/agent_test.go#newcod...
agent/agent_test.go:446: conf, err :=
agent.NewStateMachineConfig(attributeParams, servingInfo)
On 2014/04/15 17:05:38, rog wrote:
> s/attributeParams/attrParams/

Done.

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go
File cmd/jujud/bootstrap.go (right):

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go#new...
cmd/jujud/bootstrap.go:151: return fmt.Errorf("no stateinfo available")
On 2014/04/15 17:05:38, rog wrote:
> "no state info available"
> 
> good to stick to english for errors, i think.

Done.

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/bootstrap.go#new...
cmd/jujud/bootstrap.go:159: return fmt.Errorf("No stateservinginfo available")
On 2014/04/15 17:05:38, rog wrote:
> "no state serving info available"

Done.

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go#newco...
cmd/jujud/machine.go:495: return nil, nil, fmt.Errorf("no stateinfo available")
On 2014/04/15 17:05:38, rog wrote:
> s/stateinfo/state info/

Done.

https://codereview.appspot.com/88200043/diff/20001/cmd/jujud/machine.go#newco...
cmd/jujud/machine.go:591: return fmt.Errorf("no stateinfo available")
On 2014/04/15 17:05:38, rog wrote:
> ditto

Done.