src/liblink/asm5.c - Issue 88190043: code review 88190043: liblink, cmd/ld: reenable nosplit checking and test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/liblink/asm5.c

Issue 88190043: code review 88190043: liblink, cmd/ld: reenable nosplit checking and test (Closed)

Patch Set: diff -r 4873079c140c https://code.google.com/p/go/ Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/liblink/asm5.c

===================================================================

--- a/src/liblink/asm5.c

+++ b/src/liblink/asm5.c

@@ -1302,7 +1302,7 @@

rel->siz = 4;

rel->sym = p->to.sym;

rel->add = o1 | ((v >> 2) & 0xffffff);

- rel->type = R_CALL;

+ rel->type = R_CALLARM;

break;

}

if(p->pcond != nil)

@@ -1324,6 +1324,10 @@

ctxt->diag("%P: doesn't support BL offset(REG) where offset != 0", p);

o1 = oprrr(ctxt, ABL, p->scond);

o1 |= p->to.reg;

+ rel = addrel(ctxt->cursym);

+ rel->off = ctxt->pc;

+ rel->siz = 0;

+ rel->type = R_CALLIND;

break;

case 8: /* sll $c,[R],R -> mov (R<<$c),R */

« no previous file with comments | « src/cmd/link/testdata/pclntab.6 ('k') | src/liblink/asm6.c » ('j') | no next file with comments »