Issue 88160051: Allow CompoundObserver to report changes in value from added to open

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88160051: Allow CompoundObserver to report changes in value from added to open (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
arv

Base URL:
git@github.com:Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

Allow CompoundObserver to report changes in value from added to open R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/2e3aaec

Patch Set 1 #

Total comments: 3

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -20 lines)			Patch
	M	src/observe.js	View		4 chunks	+25 lines, -16 lines	3 comments	Download
	M	tests/test.js	View		4 chunks	+27 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r2e3aaec (presubmit successful).

11 years ago (2014-04-16 23:27:25 UTC) #1

arv

https://codereview.appspot.com/88160051/diff/1/src/observe.js File src/observe.js (right): https://codereview.appspot.com/88160051/diff/1/src/observe.js#newcode944 src/observe.js:944: var index = this.observed_.length / 2 - 1; Why ...

11 years ago (2014-04-17 13:46:01 UTC) #2

rafaelw

11 years ago (2014-04-17 17:37:29 UTC) #3

arv

11 years ago (2014-04-17 18:16:23 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/88160051/diff/1/src/observe.js
File src/observe.js (right):

https://codereview.appspot.com/88160051/diff/1/src/observe.js#newcode944
src/observe.js:944: var index = this.observed_.length / 2 - 1;
On 2014/04/17 17:37:29, rafaelw wrote:
> The value_ array is half as long as the observed_ array, because it only
stores
> the value of each dep, while the observed_ array stores a tuple of two values
> for each dep. 
> 
> We're computing the index position of within value into which we need to
write.
> 
> On 2014/04/17 13:46:01, arv wrote:
> > Why are we taking the the object in the middle?
> 

I see. Makes sense now. I didn't pay attention that you were doing the lookup in
a different array.

Expand All Messages | Collapse All Messages