Issue 88160: dynamic-height robustness changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88160: dynamic-height robustness changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by johnfargo

Modified:
16 years, 8 months ago

Reviewers:
shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Interested in comments on these changes. 1. Only perform auto-detection of height when document.body and document.documentElement exist, preventing size calculation of 0 when API is called before this occurs. 2. Do not resize when size auto-detection yields value of 0. The idea is to prevent gadgets from squeezing themselves to 0 height under various circumstances. While both changes are in this patch, they may be separated.

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
		features/src/main/javascript/features/dynamic-height/dynamic-height.js	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages