Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(421)

Issue 88158: Fix cloning of nodes and guard against future problems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by ihab.awad
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix Issue 985: http://code.google.com/p/google-caja/issues/detail?id=985 Adds a distinguished annotation for ParseTreeNode constructors to be invoked reflectively (e.g., when cloning a tree); adds tests for cloneability for the CSS and JS parse tree nodes; and makes a couple of minor changes to the CSS nodes (the original source of this bug) where their ctors were not allowing them to be successfully cloned.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -3 lines) Patch
M src/com/google/caja/parser/ParseTreeNode.java View 2 chunks +15 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/ParseTreeNodeContainer.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/ParseTreeNodes.java View 2 chunks +12 lines, -1 line 0 comments Download
M src/com/google/caja/parser/css/CssTree.java View 35 chunks +43 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/js/AbstractExpression.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/AbstractStatement.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ArrayConstructor.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/AssignOperation.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Block.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/BooleanLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/BreakStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/CajoledModule.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/CaseStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/CatchStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Conditional.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ContinueStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ControlOperation.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/DebuggerStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Declaration.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/DefaultCaseStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/DoWhileLoop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ExpressionStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/FinallyStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ForEachLoop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ForLoop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/FormalParam.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/FunctionConstructor.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/FunctionDeclaration.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Identifier.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/IntegerLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/LabeledStmtWrapper.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Loop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/MultiDeclaration.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Noop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/NullLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/QuotedExpression.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/RealLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Reference.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/RegexpLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ReturnStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/SimpleOperation.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/SpecialOperation.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/StringLiteral.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/SwitchStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/ThrowStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/TranslatedCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/TryStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/UncajoledModule.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/UseSubset.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/UseSubsetDirective.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/WhileLoop.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/parser/js/WithStmt.java View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/css/CssParserTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/ParserTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/CajaTestCase.java View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 2
ihab.awad
16 years, 8 months ago (2009-07-13 03:34:53 UTC) #1
Jasvir
16 years, 8 months ago (2009-07-14 22:46:00 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b