fix return value of appendChild, etc.

currently, appendChild returns null.
it's supposed to return the appended child.
similarly for insertChild, removeChild, and replaceChild.

[ihab.awad, 2009-07-13 21:04:11]

lima golf tango mike

http://codereview.appspot.com/88157/diff/1/3
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/88157/diff/1/3#newcode1341
Line 1341: throw new Error(NOT_EDITABLE);
Ah! Good catch. Thanks for adding this.

http://codereview.appspot.com/88157/diff/1/3#newcode1359
Line 1359: TameBackedNode.prototype.replaceChild = function (newChild, oldChild)
{
eep, we had the parameters named bass-ackwards-wise. Thanks for catching that
too!

http://codereview.appspot.com/88157/diff/1/3#newcode1576
Line 1576: TamePseudoNode.prototype.replaceChild = function () {
The original had the wrong signature (1 instead of 2 args); I would think it
would be better to fix the signature, as a form of documentation for code
readers, rather than delete it, even if the arguments are never used.

[felix8a, 2009-07-13 22:36:36]

http://codereview.appspot.com/88157/diff/1/3
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/88157/diff/1/3#newcode1576
Line 1576: TamePseudoNode.prototype.replaceChild = function () {
On 2009/07/13 21:04:11, ihab.awad wrote:
> The original had the wrong signature (1 instead of 2 args); I would think it
> would be better to fix the signature, as a form of documentation for code
> readers, rather than delete it, even if the arguments are never used.

but that function is not just replaceChild, it's also removeChild, etc.
there isn't a consistent signature for all those functions, so I think
it's better to have an empty signature rather than a misleading
signature.

[ihab.awad, 2009-07-13 22:41:46]

http://codereview.appspot.com/88157/diff/1/3
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/88157/diff/1/3#newcode1576
Line 1576: TamePseudoNode.prototype.replaceChild = function () {
Contact svn at http://code.google.com/p/google-caja/. Good day.