Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(612)

Issue 88152: Remove URI resolution from TemplateCompiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by ihab.awad
Modified:
16 years, 10 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modify TemplateCompiler so it no longer resolves URI-valued HTML attributes itself; instead, it relies solely on the PluginEnvironment to do all resolution.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M src/com/google/caja/plugin/templates/TemplateCompiler.java View 1 chunk +1 line, -2 lines 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java View 4 chunks +48 lines, -3 lines 3 comments Download

Messages

Total messages: 5
ihab.awad
16 years, 11 months ago (2009-07-10 21:59:21 UTC) #1
felix8a
lgtm http://codereview.appspot.com/88152/diff/1/2 File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right): http://codereview.appspot.com/88152/diff/1/2#newcode310 Line 310: final Holder<ExternalReference> savedRef = new Holder<ExternalReference>(); why ...
16 years, 11 months ago (2009-07-10 22:52:01 UTC) #2
ihab.awad
http://codereview.appspot.com/88152/diff/1/2 File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right): http://codereview.appspot.com/88152/diff/1/2#newcode310 Line 310: final Holder<ExternalReference> savedRef = new Holder<ExternalReference>(); On 2009/07/10 ...
16 years, 11 months ago (2009-07-11 00:12:59 UTC) #3
ihab.awad
@3565
16 years, 11 months ago (2009-07-11 00:13:43 UTC) #4
felix8a
16 years, 11 months ago (2009-07-11 00:17:18 UTC) #5
http://codereview.appspot.com/88152/diff/1/2
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/88152/diff/1/2#newcode310
Line 310: final Holder<ExternalReference> savedRef = new
Holder<ExternalReference>();
On 2009/07/11 00:12:59, ihab.awad wrote:
> On 2009/07/10 22:52:01, felix8a wrote:
> > why not just
> >  ExternalReference savedRef;
> > ?
> 
> It has to be final in order to be accessible from the anonymous inner class
that
> follows.

ah, yeah. ok.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b