Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 88149: cajole_html is refusing <a href="#foo"> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by felix8a
Modified:
16 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

cajole_html uses a unique PluginEnvironment that allows limited filesystem references, but barfs on most uses of #fragments. this change relaxes the restriction on #fragments. so now <a href="#foo"> is allowed, and if href="foo.html" is allowed, then href="foo.html#bar" is also allowed. there's no testcase in this change because there isn't already a test structure for any of this. (emma says 0% coverage) I might add tests later.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M src/com/google/caja/plugin/FileSystemEnvironment.java View 3 chunks +28 lines, -8 lines 1 comment Download

Messages

Total messages: 2
felix8a
16 years, 11 months ago (2009-07-10 00:08:43 UTC) #1
ihab.awad
16 years, 11 months ago (2009-07-10 18:58:10 UTC) #2
LGTM

http://codereview.appspot.com/88149/diff/1/2
File src/com/google/caja/plugin/FileSystemEnvironment.java (right):

http://codereview.appspot.com/88149/diff/1/2#newcode70
Line 70: String uristr = self.relativize(ref.getUri()).toString();
Ok, I see now how you worked around the fact that the cajoler is
pre-absolutizing the fragment, and I now see how it should not do that. Ziqing
Mao also just pointed out to me that ExternalReference *already* contains a
pair: the source FilePosition and the target URI. Check. :) So ok, we should
just fix the cajoler attribute rewriting code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b