Issue 88141: disable some tests in a headless environment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88141: disable some tests in a headless environment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by felix8a

Modified:
16 years, 8 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

it's awkward to run CajaAppletTest and DomitaTest in an automated headless test environment. this change neuters those tests if -Dtest.headless=true

Patch Set 2 : disable some tests in a headless environment #

Total comments: 2

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -12 lines)			Patch
M	build.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/demos/applet/CajaAppletTest.java	View	1	3 chunks	+20 lines, -12 lines	0 comments	Download
M	tests/com/google/caja/plugin/DomitaTest.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View		2 chunks	+19 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ihab.awad

LGTM++ http://codereview.appspot.com/88141/diff/1/3 File tests/com/google/caja/plugin/DomitaTest.java (right): http://codereview.appspot.com/88141/diff/1/3#newcode30 Line 30: import java.awt.GraphicsEnvironment; Unused import.

16 years, 9 months ago (2009-07-09 15:11:43 UTC) #2

felix8a

ping. change from previous snapshot is it now checks that test.headless == headlessness.

16 years, 8 months ago (2009-07-15 09:02:08 UTC) #3

ihab.awad

16 years, 8 months ago (2009-07-15 17:44:46 UTC) #4

LGTM++

http://codereview.appspot.com/88141/diff/8/10
File tests/com/google/caja/util/CajaTestCase.java (right):

http://codereview.appspot.com/88141/diff/8/10#newcode319
Line 319: assertTrue("test.headless=true in non-headless environment",
How about "==true"?

http://codereview.appspot.com/88141/diff/8/10#newcode325
Line 325: assertFalse("test.headless!=true in headless environment",
How about "==false"?

Expand All Messages | Collapse All Messages