Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(712)

Issue 88132: fix some debugmode issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by felix8a
Modified:
16 years, 10 months ago
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. you can't use debugmode twice on the same page. http://code.google.com/p/google-caja/issues/detail?id=637 cajole this in the testbed with debug on: <script>function f(){}</script> then try to cajole it again. the second time fails "___ reused with different debug symbols" this change fixes that by blithely allowing you to reuse ___ with different debug symbols. this is not necessarily the right fix, because two modules coexisting on the same page will stomp on each other's debugging symbols, but this simple fix reduces frustration with the testbed in the common case. 2. event handlers can screw up the debug stack and raise a spurious exception. http://code.google.com/p/google-caja/issues/detail?id=828 the current code assumes that event handlers are always top-level entry points, and it clears the debug stack at every event, but sometimes an event handler can fire while we're in middle of executing some other js, and on return from the eventhandler, debugmode tries to pop from the empty stack, causing an exception. this change fixes that in two ways: a. event handlers will not clear the debug stack. b. debugstack underflow will not raise an exception.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix some debugmode issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M src/com/google/caja/cajita-debugmode.js View 1 6 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 6
felix8a
16 years, 11 months ago (2009-07-09 00:48:28 UTC) #1
DavidSarah
http://codereview.appspot.com/88132/diff/1/2 File src/com/google/caja/cajita-debugmode.js (left): http://codereview.appspot.com/88132/diff/1/2#oldcode319 Line 319: cajita.fail('___ reused with different debug symbols'); I suggest ...
16 years, 11 months ago (2009-07-09 20:21:28 UTC) #2
felix8a
On 2009/07/09 20:21:28, DavidSarah wrote: > http://codereview.appspot.com/88132/diff/1/2 > File src/com/google/caja/cajita-debugmode.js (left): > > http://codereview.appspot.com/88132/diff/1/2#oldcode319 > ...
16 years, 11 months ago (2009-07-09 20:32:10 UTC) #3
metaweta
On 2009/07/09 20:32:10, felix8a wrote: > On 2009/07/09 20:21:28, DavidSarah wrote: > > http://codereview.appspot.com/88132/diff/1/2 > ...
16 years, 11 months ago (2009-07-10 19:05:36 UTC) #4
felix8a
16 years, 11 months ago (2009-07-10 23:00:37 UTC) #5
metaweta
16 years, 11 months ago (2009-07-10 23:46:50 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b