Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16498)

Issue 88130047: state/statecmd: remove

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rog
Modified:
10 years ago
Reviewers:
mp+216053, natefinch
Visibility:
Public.

Description

state/statecmd: remove This CL just moves code - it changes no semantics. statecmd is no longer needed and was only ever intended to be a stopgap measure. It's arguable whether the environs/manual tests and cmd/juju should be importing the server-side packages directly - that should probably be sorted out at some point in the future by judicious factoring out of appropriate functions. https://code.launchpad.net/~rogpeppe/juju-core/552-statecmd-remove/+merge/216053 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/statecmd: remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -544 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/status.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/manual/provisioner_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M state/apiserver/client/client.go View 2 chunks +1 line, -2 lines 0 comments Download
M state/apiserver/client/client_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M state/apiserver/client/machineconfig.go View 2 chunks +4 lines, -6 lines 0 comments Download
M state/apiserver/client/machineconfig_test.go View 5 chunks +5 lines, -11 lines 0 comments Download
M state/apiserver/client/status.go View 3 chunks +477 lines, -4 lines 0 comments Download
D state/apiserver/client/tools.go View 1 chunk +0 lines, -24 lines 0 comments Download
D state/statecmd/status.go View 1 chunk +0 lines, -490 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years ago (2014-04-16 10:16:43 UTC) #1
natefinch
10 years ago (2014-04-16 10:23:14 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b