Issue 88130044: worker/uniter: fix bad use of ErrorContextf

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88130044: worker/uniter: fix bad use of ErrorContextf

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
jameinel, mp+215874

Visibility:
Public.

Description

worker/uniter: fix bad use of ErrorContextf This caused a sporadic test failure, besides just being wrong. https://code.launchpad.net/~rogpeppe/juju-core/550-uniter-fix-test/+merge/215874 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/uniter: fix bad use of ErrorContextf #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/uniter/uniter.go	View		3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jameinel

10 years ago (2014-04-15 13:52:37 UTC) #2

LGTM, it feels like we should have a reliable test for this behavior, but I can
accept the change.

Expand All Messages | Collapse All Messages