Issue 88116: Support TR.sectionRowIndex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88116: Support TR.sectionRowIndex (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by felix8a

Modified:
16 years, 10 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Domita doesn't support TR.sectionRowIndex. This change fixes that.

Patch Set 1 #

Total comments: 1

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	src/com/google/caja/plugin/domita.js	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	tests/com/google/caja/plugin/domita_test_untrusted.html	View		2 chunks	+27 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ihab.awad

16 years, 11 months ago (2009-07-08 05:58:18 UTC) #2

LGTM++ (comments attached)

http://codereview.appspot.com/88116/diff/1/2
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/88116/diff/1/2#newcode308
Line 308: <td id="test-table-elements-td-b11">b11</td>
You never end up using the ID test-table-elements-td-b11; to avoid confusion,
please remove it.

Expand All Messages | Collapse All Messages