Issue 88082: Fix cloning of nodes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88082: Fix cloning of nodes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by ihab.awad

Modified:
16 years, 8 months ago

Reviewers:
Jasvir, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix http://code.google.com/p/google-caja/issues/detail?id=985. Adds more predictability to our reflective ParseTreeNode constructors, and adds tests of node cloning.

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -3 lines)			Patch
M	src/com/google/caja/parser/ParseTreeNode.java	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/ParseTreeNodes.java	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/css/CssTree.java	View	35 chunks	+43 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/js/AbstractExpression.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/AbstractStatement.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ArrayConstructor.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/AssignOperation.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Block.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/BooleanLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/BreakStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/CajoledModule.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/CaseStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/CatchStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Conditional.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ContinueStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ControlOperation.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/DebuggerStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Declaration.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/DefaultCaseStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/DoWhileLoop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ExpressionStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FinallyStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ForEachLoop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ForLoop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FormalParam.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FunctionConstructor.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FunctionDeclaration.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Identifier.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/IntegerLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/LabeledStmtWrapper.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Loop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/MultiDeclaration.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Noop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/NullLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ObjectConstructor.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/QuotedExpression.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/RealLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Reference.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/RegexpLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ReturnStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/SimpleOperation.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/SpecialOperation.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/StringLiteral.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/SwitchStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ThrowStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/TranslatedCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/TryStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/UncajoledModule.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/UseSubset.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/UseSubsetDirective.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/WhileLoop.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/WithStmt.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/css/CssParserTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/js/ParserTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

@3574

Expand All Messages | Collapse All Messages