Issue 88070: dynamic-height Chrome fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88070: dynamic-height Chrome fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by johnfargo

Modified:
16 years, 6 months ago

Reviewers:
mhermanto1, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Provided by Michael Hermanto: http://issues.apache.org/jira/browse/SHINDIG-1101

Patch Set 1 #

Total comments: 1

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
		features/src/main/javascript/features/dynamic-height/dynamic-height.js	View		2 chunks	+42 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

16 years, 7 months ago (2009-06-25 21:45:39 UTC) #2

http://codereview.appspot.com/88070/diff/1/2
File features/src/main/javascript/features/dynamic-height/dynamic-height.js
(right):

http://codereview.appspot.com/88070/diff/1/2#newcode49
Line 49: value.match(/^([0-9]+)px$/);
does "px" always show up? Might some rendering cases yield values like:
* 123
* 123em
* 123 px

...in other words, perhaps we could just drop the textual suffix and $.

Expand All Messages | Collapse All Messages