Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(610)

Issue 88069: rpc.js improvements: re-re-review (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by johnfargo
Modified:
16 years, 8 months ago
Reviewers:
shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

1. RMR, new transport for Safari < 4, Chrome < 2, and should work as a backup on several other browsers (the latter claim requires more testing). - Paves the way to sunsetting IFPC, in turn sunsetting the need for containers to host "active" relay file rpc_relay.html and configure it properly. 2. Refactoring transport code into separate "classes". This cleans up the code a bit and makes it possible to optimize later by emitting only the JS a given browser needs rather than JS for all techniques. 3. Early-message queueing. Makes it possible to call gadgets.rpc.call(...) in a container to a gadget before the gadget is initialized (or even rendered), with the call still going through when the gadget is ready. It also ensures that G -> C calls made before G -> C initialization is complete also succeed (this is much less prevalent). 4. Various cleanups including tentative backward-setup support. As a convenience and to prevent user error, makes it possible to call gadgets.rpc.setAuthToken(gadget, token); before the gadget IFRAME is rendered. While not recommended in any case, this is intended to make the library easier to use.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1415 lines, -553 lines) Patch
features/src/main/javascript/features/rpc/fe.transport.js View 1 chunk +134 lines, -0 lines 0 comments Download
features/src/main/javascript/features/rpc/feature.xml View 1 chunk +12 lines, -0 lines 0 comments Download
features/src/main/javascript/features/rpc/ifpc.transport.js View 1 chunk +156 lines, -0 lines 0 comments Download
features/src/main/javascript/features/rpc/nix.transport.js View 1 chunk +278 lines, -0 lines 0 comments Download
features/src/main/javascript/features/rpc/rmr.transport.js View 1 chunk +484 lines, -0 lines 0 comments Download
features/src/main/javascript/features/rpc/rpc.js View 21 chunks +263 lines, -553 lines 0 comments Download
features/src/main/javascript/features/rpc/wpm.transport.js View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 1
johnfargo
16 years, 10 months ago (2009-06-25 21:28:09 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b