worker/peergrouper: maintain HasVote better

worker/peergrouper: maintain HasVote better

We observed that HasVote was not being properly
maintained when SetHasVote failed on a previous
iteration.

https://code.launchpad.net/~rogpeppe/juju-core/557-peergrouper-maintain-hasvote/+merge/216359

(do not edit description out of merge proposal)

[rog, 2014-04-17 16:09:46]

Please take a look.

[dimitern, 2014-04-17 16:17:34]

LGTM with a few suggestions.

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
File worker/peergrouper/desired_test.go (right):

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
worker/peergrouper/desired_test.go:216: c.Assert(votePresent, jc.IsTrue)
Why not use c.Check in both cases?

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
worker/peergrouper/desired_test.go:231: c.Assert(votePresent, jc.IsTrue)
ditto

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker.go
File worker/peergrouper/worker.go (right):

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker....
worker/peergrouper/worker.go:167: logger.Infof("notified")
Debugf?

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker....
worker/peergrouper/worker.go:357: logger.Infof("setting HasVote=%v on machines
%v", hasVote, ms)
Debugf?

[rog, 2014-04-17 16:23:39]

Please take a look.

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
File worker/peergrouper/desired_test.go (right):

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
worker/peergrouper/desired_test.go:216: c.Assert(votePresent, jc.IsTrue)
On 2014/04/17 16:17:35, dimitern wrote:
> Why not use c.Check in both cases?

Done.

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/desired...
worker/peergrouper/desired_test.go:231: c.Assert(votePresent, jc.IsTrue)
On 2014/04/17 16:17:35, dimitern wrote:
> ditto

Done.

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker.go
File worker/peergrouper/worker.go (right):

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker....
worker/peergrouper/worker.go:167: logger.Infof("notified")
On 2014/04/17 16:17:35, dimitern wrote:
> Debugf?

debugging relic. deleted.

https://codereview.appspot.com/88000050/diff/20001/worker/peergrouper/worker....
worker/peergrouper/worker.go:357: logger.Infof("setting HasVote=%v on machines
%v", hasVote, ms)
On 2014/04/17 16:17:35, dimitern wrote:
> Debugf?

I actually think it's infrequent enough and useful enough to be an Infof.

[gz, 2014-04-17 16:23:48]

LGTM.