Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(715)

Issue 8797044: Robust distinction between IDENTIFIER and TYPE_NAME tokens. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Alok Priyadarshi
Modified:
10 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Robust distinction between IDENTIFIER and TYPE_NAME tokens. To distinguish the tokens we used to track the lexer context, which is fragile. This patch implements a better way - combine the two tokens into a common parser rule and let the parser context decide if the declaration is valid, which it already does by checking the naming conflicts. TEST=WebGL conformance tests. Committed: https://code.google.com/p/angleproject/source/detail?r=2190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1035 lines, -993 lines) Patch
M src/compiler/ParseHelper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/glslang.l View 3 chunks +29 lines, -31 lines 0 comments Download
M src/compiler/glslang.y View 16 chunks +19 lines, -14 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 6 chunks +29 lines, -31 lines 0 comments Download
M src/compiler/glslang_tab.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 146 chunks +955 lines, -909 lines 0 comments Download

Messages

Total messages: 3
Alok Priyadarshi
10 years, 11 months ago (2013-04-25 23:18:23 UTC) #1
kbr1
LGTM TBH this is on the boundary of my understanding, but it looks correct.
10 years, 11 months ago (2013-04-26 00:02:47 UTC) #2
Alok Priyadarshi
10 years, 11 months ago (2013-04-26 15:24:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r2190 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b