Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 8789046: i#1187: whole-callstack cache prototype

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by bruening
Modified:
11 years, 6 months ago
Reviewers:
zhaoqin
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Reviewer: zhaoqin@gogole.com i#1187: whole-callstack cache prototype i#1187: add a whole-callstack cache. Prototype implementation: suggestions for improvement? The performance numbers show that while it has benefits in the absence of the i#1186 find_next_fp single-frame cache, it is not as effective, so we want both. When combined with the single-frame cache it actually causes a slight slowdown on cfrac and a slight speedup on perlbench diffmail. fpra_cache_check() shows up in profiling. For every frame on a new callstack walk, we have to iterate the whole cache to look for a tail match. Any ideas on how to improve this?

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3 lines) Patch
M common/callstack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M common/callstack.c View 11 chunks +98 lines, -2 lines 0 comments Download
M drmemory/alloc_drmem.c View 1 chunk +1 line, -0 lines 0 comments Download
M drmemory/drmemory.c View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
bruening
11 years, 6 months ago (2013-04-17 04:09:35 UTC) #1
bruening
Running drheapstat on cfrac w/ and w/o this feature and comparing callstack.log: 195 unique callstacks ...
11 years, 6 months ago (2013-04-17 15:09:13 UTC) #2
bruening
perf summary: cfrac full mode: base (w/o i#1186 find_next_fp cache or i#1187 cstack cache): 51.26user ...
11 years, 6 months ago (2013-04-17 15:15:16 UTC) #3
bruening
11 years, 6 months ago (2013-04-17 15:30:51 UTC) #4
This is being abandoned for now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b