Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 8785043: [APICHANGE] Remove some Cajita/Valija cruft. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by kpreid2
Modified:
12 years, 11 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Remove ___.extend in ES5/3. * Remove .../demos/playground/setup-valija.js. @r5357

Patch Set 1 #

Patch Set 2 : Remove some Cajita/Valija cruft. #

Patch Set 3 : Remove some Cajita/Valija cruft. #

Patch Set 4 : Remove some Cajita/Valija cruft. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M src/com/google/caja/es53.js View 1 2 3 2 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 9
kpreid2
12 years, 11 months ago (2013-04-16 00:02:10 UTC) #1
felix8a
markCtor looks like it's still being used by others. let's fix those before deleting it. ...
12 years, 11 months ago (2013-04-16 00:46:10 UTC) #2
kpreid2
* Remove ___.extend in ES5/3. * Remove ___.markCtor in ES5/3. * Remove .../demos/playground/setup-valija.js.
12 years, 11 months ago (2013-04-16 16:56:36 UTC) #3
kpreid2
On 2013/04/16 00:46:10, felix8a wrote: > markCtor looks like it's still being used by others. ...
12 years, 11 months ago (2013-04-16 16:57:05 UTC) #4
kpreid2
* Remove ___.extend in ES5/3. * Deprecate ___.markCtor in ES5/3. * Remove .../demos/playground/setup-valija.js.
12 years, 11 months ago (2013-04-16 16:58:21 UTC) #5
kpreid2
* Remove ___.extend in ES5/3. * Remove .../demos/playground/setup-valija.js.
12 years, 11 months ago (2013-04-16 17:07:45 UTC) #6
kpreid2
On 2013/04/16 16:57:05, kpreid2 wrote: > New snapshot which deprecates instead of removes markCtor. On ...
12 years, 11 months ago (2013-04-16 17:08:59 UTC) #7
felix8a
In general, I'm very wary of deleting anything that's a published public interface, but I'm ...
12 years, 11 months ago (2013-04-16 17:38:53 UTC) #8
kpreid2
12 years, 11 months ago (2013-04-16 17:40:05 UTC) #9
On 2013/04/16 17:38:53, felix8a wrote:
> In general, I'm very wary of deleting anything that's a published public
> interface

Ah, I should also tag this [APICHANGE], because it is.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b