Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 87830044: Disable mongo HA set up for local provider (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by wallyworld
Modified:
10 years ago
Reviewers:
axw, mp+215797
Visibility:
Public.

Description

Disable mongo HA set up for local provider Recent changes to mongo startup to cater for replicate sets and other HA infrastructure breaks on the local provider. We don't really want HA on the local provider anyway. So this branch disables the HA setup part of mongo for the local provider. The check used is consistent with other local provider checks inside jujud (as wrong as it is) and there are no tests specifically for the local provider case (since the jujud tests just don't cater for it). But it has been tested live locally. https://code.launchpad.net/~wallyworld/juju-core/disable-local-HA/+merge/215797 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/mongo/mongo.go View 5 chunks +27 lines, -16 lines 1 comment Download
M agent/mongo/mongo_test.go View 3 chunks +20 lines, -5 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/bootstrap.go View 2 chunks +8 lines, -1 line 0 comments Download
M cmd/jujud/bootstrap_test.go View 2 chunks +4 lines, -2 lines 0 comments Download
M cmd/jujud/machine.go View 2 chunks +4 lines, -2 lines 0 comments Download
M cmd/jujud/machine_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
10 years ago (2014-04-15 03:44:47 UTC) #1
axw
On 2014/04/15 03:44:47, wallyworld wrote: > Please take a look. I really wish we didn't ...
10 years ago (2014-04-15 04:05:01 UTC) #2
axw
10 years ago (2014-04-15 04:05:41 UTC) #3
Forgot to mail...

https://codereview.appspot.com/87830044/diff/1/agent/mongo/mongo.go
File agent/mongo/mongo.go (right):

https://codereview.appspot.com/87830044/diff/1/agent/mongo/mongo.go#newcode291
agent/mongo/mongo.go:291: mongoCmd += " --replSet " + replicaSetName
--keyFile is also only relevant to HA
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b