Issue 878047: code review 878047: syscall: match linux Setsid function signature to darwin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 878047: code review 878047: syscall: match linux Setsid function signature to darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by adg

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

syscall: match linux Setsid function signature to darwin SETSID does return an errno - any reason why it has been done this way in zsyscall_linux_* ? Otherwise it should be the same as darwin. From SETSID(2) on my Linux box: ERRORS On error, -1 is returned, and errno is set. Fixes issue 730

Patch Set 1 #

Patch Set 2 : code review 878047: syscall: match linux Setsid function signature to darwin #

Patch Set 3 : code review 878047: syscall: match linux Setsid function signature to darwin #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
M	src/pkg/syscall/syscall_linux.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-19 01:22:36 UTC) #1

rsc

LGTM If there was a reason, it is long forgotten. I suspect it was just ...

14 years, 11 months ago (2010-04-19 03:07:29 UTC) #2

adg

14 years, 11 months ago (2010-04-19 03:12:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0311734023b0 ***

syscall: match linux Setsid function signature to darwin

SETSID does return an errno - any reason why it has been done this
way in zsyscall_linux_* ? Otherwise it should be the same as darwin.

From SETSID(2) on my Linux box:

ERRORS
       On error, -1 is returned, and errno is set.

Fixes issue 730

R=rsc
CC=golang-dev
http://codereview.appspot.com/878047

Expand All Messages | Collapse All Messages